Skip to content

Click on "Expand all files" does not correctly expand some files

Problem

When some files are collapsed in a merge request diff, there are two ways to expand them:

  1. Top warning has CTA to "expand all files"
  2. Individual files have an option to "click to expand it"

Currently, when the top CTA button is clicked, some of the files are NOT expanded but instead offer the option to dowload. This should not the case, the files should be expanded the same way they are when individually expanded.

expand_all_bug

Steps to reproduce

  1. Go to gitlab-com/www-gitlab-com!66075 (diffs)
  2. Click Expand All Files or Expand All
  3. Notice the last file shows "Download" button.

Example Project

What is the current bug behavior?

Screenshot_2020-10-28_at_18.07.11

What is the expected correct behavior?

Screenshot_2020-10-28_at_18.07.57

Possible fixes

We need to make sure the same action is triggered when expanding all in bulk as it is triggered individually.

Edited by André Luís