Clean up remaining licensed feature flags
Background
Feature Flags of type licensed have been deprecated and are being removed. This is because the use of them was confusing and conflicted with the development flags are used.
See #259611 (closed) for more information on the reasoning and context of this removal.
We have some licensed feature flags that are remaining:
- Feature flag - DRI
-
resource_access_token- @dblessing (handover from @asubramanian1) -
ci_secrets_management- @krasio -
feature_flags_related_issues- @jagood -
group_coverage_reports- @ahegyi -
group_wikis- @toupeira (or @.luke ) -
incident_sla- @seanarnold -
swimlanes- @cablett or @jarka -
minimal_access_role- @mksionek
What to do
You've been pinged in this issue. Now what?
- Determine if the check for the feature is still required
- Remove the check, or migrate it to a
developmentfeature flag
To check for licensed features, add a dedicated feature flag under a different name and check it explicitly. If you want to check a licensed feature with a feature flag, do it explicitly:
Feature.enabled?(:licensed_feature_feature_flag, project) &&
project.feature_available?(:licensed_feature)
If you have any questions, feel free to get in contact with @seanarnold or @ayufan.
Edited by Sean Arnold