[Feature flag] Rollout of include_child_pipeline_jobs_in_reports
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
What
Enable and then remove the :include_child_pipeline_jobs_in_reports feature flag.
This feature flag implements the feature described in #215725 (closed) where MR widget can display any reports generated by child pipelines. Previous to this change the MR widget displayed only reports directly belonging to the MR head pipeline and not to any of its child pipelines.
Owners
- Team: ~"group::continuous integration"
- Most appropriate slack channel to reach out to:
#g_ci - Best individual to reach out to: @fabiopitino
Expectations
What are we expecting to happen?
We are expecting any reports being generated by child pipelines to be visible by the parent pipeline and included in the relative MR widget.
What might happen if this goes wrong?
If someone has configured child pipelines to generate reports that were never previously surfaced to the MR widget this will suddenly show them which is expected. Given that the pool of builds where we are going to look for reports will increase (including all pipelines in the hierarchy) it may cause an increase in the response time for the endpoints returning pipeline reports. We need to measure if this is acceptable.
What can we monitor to detect problems with this?
- Response time for endpoints returning MR reports https://dashboards.gitlab.net/d/web-rails-controller/web-rails-controller?orgId=1&var-PROMETHEUS_DS=Global&var-environment=gprd&var-stage=main&var-controller=Projects::MergeRequestsController&var-action=All
- No errors introduced in Sentry for the same endpoints
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlabproject -
gitlab-org/gitlab-comgroups
Roll Out Steps
-
Enable on staging ( /chatops run feature set feature_name true --staging) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true) -
Coordinate a time to enable the flag with #productionand#g_deliveryon slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production(/chatops run feature set feature_name true) -
Cross post chatops Slack command to #support_gitlab-com(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #productionchannel