Strange behaviour when overriding multiple merge-request approval rules
I have two MR-approval rules set up:
I created a MR and changed the number of required approvals from Testing to 1, while leaving the required number of "Any eligible user" approvals at 0.
An "eligible user" approved the MR, and what appeared on my end didn't match what appeared in the Testing user's browser.
My browser:
Note: Next to "Testing" in the Approvers column appeared "Overridden" in grey (this doesn't appear in the screenshot probably because I captured it after making the changes described below).
Testing user's browser:
Note: the Testing user is a Reporter.
In the process of trying to reproduce this issue, I created a new MR and noticed the same odd behaviour I'd seen with the first one: when I increased the number required approvals from Testing to 1, the two approval rules were replaced by a single one requiring 1 approval from "Any eligible user". When I reduced the # of required approvals back to 0, both rules reappeared.
I then tried increasing the default number of required approvals in the Settings|General from each group to 1, and the rules when creating a new MR seemed to work as expected. Strangely, after I then reduced the default number of required approvals back to 0 in both rules, I no longer saw the same "disappearing rule" issue when creating/editing a MR, and neither did I see the grey "Overridden" text next to the Testing rule. Unfortunately, what appears in the Testing user's browser didn't change.
I suspect there's some required initialization that happened only when I set a non-zero number of approvers in the settings, and which persists now even after I reduced the default required number of approvers to 0 – so I'd suggest creating a new project to try and reproduce this issue (we're using GitLab 13.2.6-ee).
Something else I noticed which could possibly shed light on this issue – in the test MR that I created, I see the following:
Note the wording "Requires 2 more approvals from Testing." – I'd expect it to say something like "Requires 2 more approvals, 1 from Testing".
After I click Approve, I see:
