Skip to content

'+' character at start of file/folder names are not working correctly

Summary

There are many issues with + character at the start of file/folder names. This is how MATLAB namespaces code.

Observed issues

File browser: Clicking on a folder that contains a + at the beginning does not navigate correctly.

GitLab IDE: Many issues with files/folders that start with +.

  • Creates 2 files when adding a file. One named %2Bfilename, other named +filename. Both end up being committed.
  • Failure to open correct file when clicking on the files starting with +
  • Failure to open any file clicking on

Steps to reproduce

Create any folder or file in that starts with a + symbol and attempt to interact with it.

Example Project

https://gitlab.com/PeteAndersen/plus_demo_repo

What is the current bug behavior?

See Observed Issues

What is the expected correct behavior?

Files/folders starting with + function the same as GitLab 13.4 and prior

Relevant logs and/or screenshots

File Browser:

image

Gitlab IDE:

image

Merge request:

image

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Edited by Peter