Investigate deprecating global_id in favour of id in DastScannerProfile mutations
The following discussion from !40225 (merged) should be addressed:
-
@.luke started a discussion: (+4 comments) @philipcunningham I wonder if this change was necessary? The
id
field was already expressed as a Global ID. I think we can freely swap aGraphQL::ID_TYPE
in a type with::Types::GlobalIDType[::DastScannerProfile]
because the client receives both as aString
, and in this case, both fields produce the sameString
. cc @alexkalderimis to fact-check me here🙂 .
@philipcunningham I wonder if we could:
- Change the
id
field to be a::Types::GlobalIDType[::DastScannerProfile]
- un-deprecate
id
- deprecate
global_id
It may seem a bit odd to un-deprecate, but I think this should be fine. Deprecating
global_id
at least allows a non-breaking change going forward (rather than revert of this MR).It'd be a shame for this type to not have an
id
field, when it could keep it.