[Feature flag] Enable API json content type
What
Remove the :api_always_use_application_json
feature flag.
Remove lib/api/api.rb
code introduced in !46133 (diffs) but keep content_type :json, 'application/json'
Owners
- Team: ~"group::ecosystem"
- Most appropriate slack channel to reach out to:
#g_TEAM_NAME
- Best individual to reach out to: NAME
Expectations
What are we expecting to happen?
Default content type for API changes from txt to json. See https://gitlab.com/gitlab-org/gitlab/-/issues/228903 and #250342 (closed)
What might happen if this goes wrong?
Some API who rely on defaults being txt
might fail or misbehave.
What can we monitor to detect problems with this?
https://dashboards.gitlab.net/d/api-main/api-overview?orgId=1 => api error ratio
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-org
/gitlab-com
groups - ...
Roll Out Steps
-
Enable on staging ( /chatops run feature set api_always_use_application_json true --staging
) -
Test on staging -
Ensure that documentation has been updated. MR: !53231 (merged) -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab api_always_use_application_json true
) -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set api_always_use_application_json true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Enable feature flag by default and add changelog entry !54479 (merged) -
Remove feature flag => !56777 (merged) -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Edited by Dmytro Zaporozhets (DZ)