File Lock icon missing in Web IDE
While @rdickenson and I were researching #228965 (closed), we discovered that the file lock icon is not displaying properly in the WebIDE. The WebIDE file lock icons were added in !3278 (merged) (see screenshots).
I added an LFS lock file locally, and the icon shows up:
But when I check in the IDE, there is no icon. There should be one in the file list, and one in the tab:
@psimyn Took a quick peek for me, and agrees that it's probably a bug. When checking with vue tools, he found:
Also, from Simon's testing comments in #228965 (comment 431612177):
To get the icon to show up using devtools:
- Install vue devtools extension (or the firefox version)
- Go to webIDE, open browser devtools, select the Vue tab
- Go to Settings tab for vue devtools, and enable "Editable props" toggle
- Go back to the Components toggle
- Use the filter bar to search for "file-status-icon" (no quotes)
- Click on the file-status-icon component on the left side
- On the right side, under "Props", expand the "file" prop
- There should be an entry that says 'file_lock: undefined`. Hover over that then click the pencil icon to edit
- Enter something like the following:
{"user":{"name":"Simon"}}
A lock icon appears!
Also, the tooltip max not be rendering correctly, as Simon noticed when he forced the icon to show up with devtools:
Edited by Marcel Amirault