Groups joined by email invitation or by request do not show up on dashboard notifications settings

Summary

Groups joined by email invitation or by request do not show up on the dashboard notifications settings page.

Some preliminary debugging shows that the cause is source_type not being set to Namespace on the NotificationSetting object when it is created.

Steps to reproduce

  1. Request access to a group or accept an email invitation to join a group
  2. View your notifications settings page

Workaround

  1. Go to the group page
  2. Change notification level using the dropdown
  3. Group now appears on notifications settings page

Example Project

This affects groups rather than projects. I'm not sure if all groups are affected, but I would think so.

What is the current bug behavior?

Group which you join by email invitation or by request do not show up on the dashboard notifications settings page.

What is the expected correct behavior?

Group which you join by email invitation or by request should show up on the dashboard notifications settings page.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Assignee Loading
Time tracking Loading