Support labeling Merge Request review discussions
Problem to solve
Currently every comment on a MR diff is considered actionable and every comment is given the same weight.
What if a user wants to leave a comment that does not need to be resolved (i.e. a note: or a praise:)? What if a user wants to highlight certain comments over others (i.e. a nitpick: vs. issue: vs. suggestion:)?
Let's find a way to support labeling MR comments!
Context
I like to label my comments when I review MR's. Here's some examples:
| question: | nitpick: | praise: |
|---|---|---|
 |
 |
 |
| nitpick (non-blocking): | issue: |
|---|---|
 |
 |
Crucible also supports categorization:
| Defect | Explanation |
|---|---|
 |
 |
Proposal
Let's expose a semantic type property for comments in our API. These values can come from parsing comments which follow this format:
**<type> (decoration):**Once we can parse a "type" or "decoration" from a comment, then we can do cool things like have a configurable list of resolvable / unresolvable threads based on a certain type.
side note: It'd be pretty neat if GitLab supported praising as a first class feature. Applications that natively promote positive communication lead to happy people.