MR creators should not be assigned as a reviewer in the MR reviewer feature

MR creators should not be assigned as a reviewer in the MR reviewer feature, introduced in %13.5.

This proposal means in the two ways:

1. MR creators cannot assign themselves as a reviewer.
2. Non-MR creators cannot assign the MR creator of the MR as a reviewer to that MR.

Adapted from Question 1 of #246905 (comment 429766274)

cc @sming-gitlab

changed milestone to %13.5

added Category:Code Review Workflow backend devopscreate featureenhancement frontend groupsource code merge requests sectiondev typefeature labels

mentioned in issue #246905 (closed)

added to epic &1823

changed epic to &4560

added [deprecated] Accepting merge requests label

@tnir @danielgruesso I don't think we should go out of our way to block MR authors from being added as reviewers. Most of the times it can be counter-intuitive, but there are cases where it could make sense. For example, I created !41402 (merged) to kick-start some of the work, but I didn't follow through with it and delegated the work to an engineer. As a Product Designer, I will need to review the UX of that MR, so it should be possible to add me as a reviewer.

So I don't see much value in creating and maintaining this restriction.

@pedroms Thanks for your comment, but it might be a de facto standard around reviewers like GitHub. Got it for you being a reviewer!

changed milestone to %13.6

added missed:13.5 label

Removing the milestone here just so that we can account for all the issues in the epic to see which we want to prioritize.

changed milestone to %Backlog

removed featureenhancement label

Setting label(s) Category:Source Code Management based on groupsource code.

added Category:Source Code Management label

added reviewers label

added groupcode review label and removed groupsource code label

closed