Invalid prop in `mount_sidebar`

Problem

on GDK, as an anonymous user, view a merge request and you will see this error in the JavaScript console. editable is omitted in the JSON response:

{"time_estimate":0,"total_time_spent":0,"human_time_estimate":null,"human_total_time_spent":null,"participants":[{"id":1,"name":"Adm

image

Solution

Sometimes the data attributes being used for init don't exist. Need to parseBoolean for the props here: https://gitlab.com/gitlab-org/gitlab-ce/blob/1d229689588e0e22b5cee57f6c8d2ddcc7f0822b/app/assets/javascripts/sidebar/mount_sidebar.js#L68

VueJS 8
    mountLockComponent mount_sidebar.js:66
    mountSidebar mount_sidebar.js:134
    mountSidebar mount_sidebar.js:42
    default sidebar_bundle.js:9
    <anonymous> index.js:8
Edited Aug 14, 2020 by 🤖 GitLab Bot 🤖
Assignee Loading
Time tracking Loading