Follow-up from "Add support for manual bridges for CI pipelines"
The following discussion from !44011 (merged) should be addressed:
-
@fabiopitino started a discussion: Given that this is now duplicate with
Entry::Build
, should we move this validation toEntry::Processable
module?We could do something similar to
PROCESSABLE_ALLOWED_KEYS
. WDYT? -
@fabiopitino started a discussion: Could this be moved to
Entry::Processable
? -
@fabiopitino started a discussion: Could we move
action?
toProcessable
and have here a temporary override according to the feature flag state?class Ci::Processable def action? # we would control in the entry validation whether `delayed` # is allowed or not. %w[manual delayed].include?(self.when) end end class Ci::Bridge override :action? def action? return false unless ::Gitlab::Ci::Features.manual_bridges_enabled?(project) super end end
-
@fabiopitino started a discussion: Should this and relative spec from
Ci::Build
be moved toCi::Processable
to remove duplication?
/cc @furkanayhan
Edited by Furkan Ayhan