Skip to content

Improve commit override UI

The squash and merge commit override feature is a tremendous improvement but the interface takes up too much space and doesn't help users write good commit messages. We should make this interface more loveable.

Proposal

  1. Baseline of Modify commit messages is wrong
  2. Hover style feels over the top and very heavy – can we avoid adding a whole row to the merge widget that is always visible? And whole row is still visible. This seems like a waste of space.
  3. Height – the commit boxes fit 8 lines of text. We should make this three of four lines max
  4. Line width - the first line of a commit message shouldn't be over 50 characters, and the following lines should be less than 80 – we should provide some sort of feedback to help users know where these limits are.
Screenshots
Issue Screenshot
1. Baseline Screen_Shot_2019-02-08_at_5.15.59_PM
2. Hover Screen_Recording_2019-02-08_at_5.09.23_PM
3. Height Screen_Shot_2019-02-08_at_5.20.50_PM
4. Line width Screen_Shot_2019-02-08_at_5.19.54_PM

Links / references