Collapsible diffs are sometimes easy to miss

Problem to solve

Collapsible diffs that are between many changed files are easy to miss. For example, if the collapsed diff is between images:

Screenshot_2019-02-05_WIP_Merge_EE_docs_into_CE___21089____Merge_Requests___GitLab_org_GitLab_Community_Edition

Target audience

  • Sasha, Software Developer, https://design.gitlab.com/research/personas#persona-sasha

Further details

Missing on reviewing changes can be really bad, since it might result in a bug that otherwise would have been spotted by the reviewer.

Proposal

Make it visually apparent that the diff is collapsed. An MVC would be to add an icon like we have for empty states. That will make the height of the collapsed diff bigger, so it will be spotted more easily.

GitHub does this:

Screenshot_2019-02-05_axilleas_gitlabhq

What does success look like, and how can we measure that?

Less irritated developers and missed files in code review. Not sure how we can measure that.

Edited Feb 05, 2019 by Achilleas Pipinellis
Assignee Loading
Time tracking Loading