Skip to content

Follow-up from "Resolve problem with rendering thumbsup emoji"

The following discussion from !44818 (merged) should be addressed:

  • @alexkalderimis started a discussion: (+3 comments)

    I think moving the reference filter for vulnerabilities to a different section so it has a different precedence is OK as quick fix but it has the problems that:

    • it is unintuitive. A developer might see it as miscategorized, move it, and wonder why things fail
    • it is now impossible to get a pipeline that has filters but not this reference filter

    I think the correct solution is either:

    • Negative look around in the reference pattern to detect the emoji colons. This would work for this situation, but is brittle and narrow in scope
    • we rethink the filter sets in the pipeline by, for example, adding priorities to each one, and sorting them by those when constructing the pipeline
    • adding comments explaining the conflict
    • move to adopt a different reference syntax really quite urgently. The markdown already looks like ASCII soup, and discoverability is low.

    Considering how common the +1 string must be, I'm surprised this hasn't shown up more generally

Implementation Plan

  1. Roll-back/remove the feature
Edited by Thiago Figueiró