Skip to content

Address Techincal Debt Surrounding nav_tabs in the ProjectsHelper

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The following discussion from gitlab-ce!24540 should be addressed:

  • @dosuken123 started a discussion: (+3 comments)

    Isn't this essentially same with

    diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb
    index 2a24aa2a382..535ee00547c 100644
    --- a/app/helpers/projects_helper.rb
    +++ b/app/helpers/projects_helper.rb
    @@ -296,7 +296,11 @@ module ProjectsHelper
         nav_tabs = [:home]
     
         if !project.empty_repo? && can?(current_user, :download_code, project)
    -      nav_tabs << [:files, :commits, :network, :graphs, :forks, :releases]
    +      nav_tabs << [:files, :commits, :network, :graphs, :forks]
    +    end
    +
    +    if !project.empty_repo? && can?(current_user, :read_release, project)
    +      nav_tabs << :releases
         end
     
         if project.repo_exists? && can?(current_user, :read_merge_request, project)

    ?

    What's the purpose of get_project_nav_tab_abilities method?

Edited by 🤖 GitLab Bot 🤖