Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,919
    • Issues 34,919
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,227
    • Merge Requests 1,227
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #262686

Closed
Open
Opened Oct 06, 2020 by Markus Koller@toupeira🌴Maintainer

NSM Wiki: Add unique user counter for wiki page and design views with Usage Ping

Summary

In #218161 (closed) / !38784 (merged) we added Usage Ping tracking for wiki page views, but we're only counting the absolute number of page view events.

Proposal

Also track the number of unique users viewing wiki pages, in addition to creates/updates/deletes which are already tracked.

It looks like this is currently implemented in lib/gitlab/usage_data_counters/track_unique_events.rb, which gets called automatically for all events that create an Event record. We don't do that for page views, so we can probably just manually increase the counter at https://gitlab.com/gitlab-org/gitlab/-/blob/8b272bb8fddbfa23460bab54787f513eaddff8bf/app/controllers/concerns/wiki_actions.rb#L70.

Caveats

  • We haven't implemented activity tracking for group wikis yet, so for those we'd only count the manually tracked views (and not creates/updates/deletes)
    • #209306
  • In #218161 (closed) we're only tracking page views in the browser and not GET requests through the API.
    • #250694
Edited Oct 06, 2020 by Christen Dybenko
Assignee
Assign to
13.6
Milestone
13.6 (Past due)
Assign milestone
Time tracking
Nov 6, 2020
Due date
Nov 6, 2020
Reference: gitlab-org/gitlab#262686