Some small changes in a large diff are not shown
Summary
On at least two Golang projects now, I've noticed that the vendor/vendor.json
file appears not to be changed in merge requests that update a lot of dependencies. Inspecting the commits manually shows that the vendor/vendor.json
file has changed - there's just no indication of it in the merge requests changes tab.
Steps to reproduce
???
Example Project
- gitlab-workhorse!325 (diffs) ("294 changed files")
- gitlab-elasticsearch-indexer!13 (diffs) ("184 changed files") )
What is the current bug behavior?
The MR pretends some files have not changed
What is the expected correct behavior?
It is absolutely essential that we should be able to see every changed file, even if we can't see the changes made
Output of checks
This bug happens on GitLab.com
Possible fixes
Unsure. It may be a redux of https://gitlab.com/gitlab-org/gitlab-ce/issues/49907 ? cc @oswaldo
I know we stop displaying after 1,000 files, but we have less than that in both these MRs.
The actual number of changes for the Gitaly MR, as output by git diff master --stat
is:
781 files changed, 295715 insertions(+), 42796 deletions(-)
So still under 1000-file limit. I don't see an obvious reason to stop at 184.
One thing I do notice is that both MRs seem to output ~6MiB of JSON. Perhaps that's the limit?
I still think we should be outputting (and showing) every changed file, even if, for large MRs like this, we completely skip the content of every file to make it possible.