Ensure review app deployment jobs do not finish before deployment is actually complete

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Problem to solve

Review app deploys are dependent on an intermediary job (sidekiq) that replicates the content from the build to the actual review app instance. The pipeline finishes, but this step can wait for an indefinite time. This is not ideal because it's confusing to the user why the job is showing as finished but the review app is not updated.

This behavior is seen on Pages deployments (i.e., gitlab-org/www-gitlab-com). Not sure if it is relevant in other cases.

Target audience

Review apps users

Further details

N/A

Proposal

There are a couple ways we can help this:

• Wait for the sidekiq job to complete before marking the review app deployment pipeline as complete, this will make it clear that there is a delay
• Get rid of the intermediary sidekiq job and connect the pipeline directly to the deployment. This also makes it clear what's happening, and is potentially faster.

What does success look like, and how can we measure that?

Review app deployments do not report that they are complete before they are actually available.

Links / references