Skip to content

Remove feature flag PUSH_RULES_SUPERSEDE_CODE_OWNERS

What

Remove the :push_rules_supersede_code_owners feature flag ...

Related MR: !44126 (merged) Related Issue: #35097 (closed)

Owners

  • Team: Source Code
  • Most appropriate slack channel to reach out to: #g_create_source-code
  • Best individual to reach out to: @marc_shaw

Expectations

Users can push directly to a branch, overriding the codeowners file if they are allowed to push

What are we expecting to happen?

A set of users can push directly to a branch

What might happen if this goes wrong?

User's push directly to branch by mistake

What can we monitor to detect problems with this?

Beta groups/projects

If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.

  • gitlab-org/gitlab project
  • gitlab-org/gitlab-com groups
  • ...

Roll Out Steps

  • Enable on staging (/chatops run feature set feature_name true --staging)
  • Test on staging
  • Ensure that documentation has been updated
  • Enable on GitLab.com for individual groups/projects listed above and verify behaviour (/chatops run feature set --project=gitlab-org/gitlab feature_name true)
  • Coordinate a time to enable the flag with #production and #g_delivery on slack.
  • Announce on the issue an estimated time this will be enabled on GitLab.com
  • Enable on GitLab.com by running chatops command in #production (/chatops run feature set feature_name true)
  • Cross post chatops Slack command to #support_gitlab-com (more guidance when this is necessary in the dev docs) and in your team channel
  • Announce on the issue that the flag has been enabled
  • Remove feature flag and add changelog entry
  • After the flag removal is deployed, clean up the feature flag by running chatops command in #production channel
Edited by Sean Carroll