Missing approvers empty circles on MR are an eye-sore

Summary

Missing approvers on an MR are listed once as avatars, and then directly under that there are a set of empty circles, one for each missing approver, mal-aigned.

It is unnecessary to have the empty circles for the missing approvers as the same information is already provided diretly above it, but if those circles are important then there is some bug causing them to be rendered as if owned by a screen real-estate tycoon who forgot to employ an architect.

Steps to reproduce

  1. Create an MR with 16 required approvers
  2. Two of those people approve the MR

Example Project

coala/package_manager!94 (merged)

What is the current bug behavior?

It should show "Requires 14 more approvals" followed by 14 avatars. Then under that "Approved by" And again under that are two avatars in a vertical column of one avatar per row, of the people who have approved the MR.

Then in a mal-aligned vertical column, there are empty circles for missing approvers. These empty circles are not in the same column as the approvers avatars, and the empty circles are larger than the avatars.

What is the expected correct behavior?

Either the empty circles are placed under the existing avatars, or to reduce wasted screen real estate, place them horizontally or even remove the empty circles.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

Edited Jun 08, 2017 by Mark Fletcher
Assignee Loading
Time tracking Loading