FOSS broken master in spec/services/merge_requests/create_service_spec.rb, spec/services/merge_requests/update_service_spec.rb
https://gitlab.com/gitlab-org/gitlab-foss/-/jobs/765788973:
Failures:
1) MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request contains reviewers who can read the merge_request
Failure/Error: expect(execute.reviewers).to contain_exactly(reviewer1, reviewer2)
expected collection contained: [#<User id:111 @user111>, #<User id:112 @user112>]
actual collection contained: [#<User id:111 @user111>]
the missing elements were: [#<User id:112 @user112>]
Shared Example Group: "reviewer_ids filter" called from ./spec/services/merge_requests/update_service_spec.rb:197
# ./spec/support/shared_examples/services/merge_request_shared_examples.rb:35:in `block (7 levels) in <top (required)>'
# ./spec/spec_helper.rb:340:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:331:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (2 levels) in <top (required)>'
2) MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request with multiple_merge_request_reviewers feature on allows multiple reviewers
Failure/Error: expect(execute.reviewers).to contain_exactly(reviewer1, reviewer2)
expected collection contained: [#<User id:147 @user147>, #<User id:148 @user148>]
actual collection contained: [#<User id:147 @user147>]
the missing elements were: [#<User id:148 @user148>]
Shared Example Group: "reviewer_ids filter" called from ./spec/services/merge_requests/update_service_spec.rb:197
# ./spec/support/shared_examples/services/merge_request_shared_examples.rb:44:in `block (8 levels) in <top (required)>'
# ./spec/spec_helper.rb:340:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:331:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (2 levels) in <top (required)>'
Finished in 23 minutes 7 seconds (files took 46.57 seconds to load)
3854 examples, 2 failures, 3 pending
Failed examples:
rspec './spec/services/merge_requests/update_service_spec.rb[1:1:1:12:1:2:1:1:1:1]' # MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request contains reviewers who can read the merge_request
rspec './spec/services/merge_requests/update_service_spec.rb[1:1:1:12:1:2:1:1:1:2:1]' # MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request with multiple_merge_request_reviewers feature on allows multiple reviewers
https://gitlab.com/gitlab-org/gitlab-foss/-/jobs/765788979:
Failures:
1) MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request contains reviewers who can read the merge_request
Failure/Error: expect(execute.reviewers).to contain_exactly(reviewer1, reviewer2)
expected collection contained: [#<User id:111 @user111>, #<User id:112 @user112>]
actual collection contained: [#<User id:111 @user111>]
the missing elements were: [#<User id:112 @user112>]
Shared Example Group: "reviewer_ids filter" called from ./spec/services/merge_requests/update_service_spec.rb:197
# ./spec/support/shared_examples/services/merge_request_shared_examples.rb:35:in `block (7 levels) in <top (required)>'
# ./spec/spec_helper.rb:340:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:331:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (2 levels) in <top (required)>'
2) MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request with multiple_merge_request_reviewers feature on allows multiple reviewers
Failure/Error: expect(execute.reviewers).to contain_exactly(reviewer1, reviewer2)
expected collection contained: [#<User id:147 @user147>, #<User id:148 @user148>]
actual collection contained: [#<User id:147 @user147>]
the missing elements were: [#<User id:148 @user148>]
Shared Example Group: "reviewer_ids filter" called from ./spec/services/merge_requests/update_service_spec.rb:197
# ./spec/support/shared_examples/services/merge_request_shared_examples.rb:44:in `block (8 levels) in <top (required)>'
# ./spec/spec_helper.rb:340:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:331:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:327:in `block (2 levels) in <top (required)>'
Finished in 23 minutes 7 seconds (files took 46.57 seconds to load)
3854 examples, 2 failures, 3 pending
Failed examples:
rspec './spec/services/merge_requests/update_service_spec.rb[1:1:1:12:1:2:1:1:1:1]' # MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request contains reviewers who can read the merge_request
rspec './spec/services/merge_requests/update_service_spec.rb[1:1:1:12:1:2:1:1:1:2:1]' # MergeRequests::UpdateService execute valid params behaves like reviewer_ids filter filter_reviewer with reviewer_ids when the current user can admin the merge_request when merge_request_reviewer feature is enabled with reviewers who can read the merge_request with multiple_merge_request_reviewers feature on allows multiple reviewers