Discord Integration/Webhook Improvements
With the new discord webhook support from gitlab-ce#21635 I have noticed some possible improvements that could be made. (Due to the similarity between the slack integration and Discord integration most of these issues and points are also likely true for slack, though I am not certain of this.)
-
The Sign In embed in all of the messages looks pretty bad... I would suggest wrapping the links with angled brackets [Like This](<http://link.tld>)
to suppress the embed from being inserted by discord. (I have not been able to test this as -
In the image you can see that it is announcing that there has been a new version tagged. The link however goes to the commit list for that tag, rather than the tags page for that tag. I feel like the tags page is what most people would expect to see when clicking that link. If they want the commits for that tag they can easily click the "Browse Commits" button.
-
In the following image the url in the embed for the changes comparison has superfluous ))
at the end of it, which ofc makes the link not work. This is present in all compare link embeds... though using the angle bracket trick/not providing them (not sure if these are sent in the message or if discord is generating these) on these is probably a good idea too as they do not add useful information to the message
-
When issues are opened there is no link to the issue provided. (an embed with text from the issue would be good to add aswell) -
There are no embeds for when merge requests are opened, this would be nice, especially due to the fact that they exist for comments. -
Comments on merge requests have an embed with the content of the comment where as comments on issues have what appears to be the discord auto-generated embeds with the content of the issue rather than the content of the comment. -
Some consistency is broken with some of the notifications' formatting, for instance, most notifications are {user} {took action} {relevant link} in/on {link to repo}
but opening an issue for example produces[{link to repo}] {action taken} by {user_displayname} ({username})