Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 54.9k
    • Issues 54.9k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1.5k
    • Merge requests 1.5k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #25825
Closed
Open
Issue created Dec 17, 2018 by GitLab SecurityBot@gitlab-securitybotReporter

Possible DoS when requesting profile events, limit parameter is NOT checked for an upper bound

HackerOne report #463010 by brandonnnn on 2018-12-14:

Summary:

Sending a GET request to a profile activity page (https://gitlab.com/PROFILENAME?limit=X) seems to have no upper bound, and appears to be an expensive operation.

Description:

The standard 10 limit which you call when visiting a profile took 700ms and was 19.52KB. When testing with 100 limit, it took 2,287ms and was 190.62KB. I only tested up to 1000 limit, which took 11,599ms, and returned an incomplete JSON payload of 1.76MB.

Some simple extrapolation would mean a request with a 50,000 activity limit would take roughly 9 minutes and return a ~93MB payload (if it managed to finish at all, which it seems like it wouldn't).

Steps To Reproduce:

  1. Use curl to request the profile activity (I chose a user with >10k commits): [REDACTED]
  2. Wait for the operation to return an incomplete JSON payload

Supporting Material/References:

  • [Screenshot of developer console sending requests][REDACTED]

Impact

Denial of Service

Edited Jul 06, 2022 by Costel Maxim
Assignee
Assign to
Time tracking