Skip to content

"close" in the commit message does not close the issue

Summary

After upgrading to 13.4.1 I have noticed that Close https://<domain>/apps/<name>/-/issues/4 does not close the issues anymore.

It's successfully recognised as the issue has a back reference to the commit: @ivan mentioned in commit b9d2ca8b 7 minutes ago, but the issue is kept not closed. It happened couple times earlier but I thought it might be some intermittent glitch. Apparently it's not.

Steps to reproduce

  1. Create an issue in a repository
  2. Commit it with a message that contains Close <full url to the issue> line
  3. Push

Example Project

What is the current bug behavior?

At the moment the issue stays not closed.

What is the expected correct behavior?

It should be closed.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

It's the helm managed deployment, 13.4.1-ee (4b9c8135cd9)


(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes