Mark files as "reviewed" during code review
Problem to solve
As a MR reviewer I often find myself doing the following:
- go to Diff view
- go through list of changed files, and collapse the files I'm happy with or have no questions about
- start reviewing the remainder file by file
- collapse each file when I'm "done" with it
I do this a lot and I've started to notice it's a bit fragile. I often open the same MR in two tabs, one with the comments and one with the diffs. Or I might get interrupted and return to the MR in another tab, having lost or forgotten about the tab I was collapsing diffs in.
The problem I'm having is that each time I return to an unfinished review I need to go through the entire diff again and collapse the files I "don't care about".
Further details
My goal is to be able to resume a review with minimal overhead and to manage the complexity of the review work. When a diff spans dozens of files it's hard to focus on the things that matter, and to make progress (not read the same diff over and over again). Collapsing diffs helps me do that.
Proposal
What I would like is some way to mark files as OK, and to have a new MR diff tab default to having OK files collapsed. Maybe "mark as OK" just means "collapse the diff".
What does success look like, and how can we measure that?
(If no way to measure success, link to an issue that will implement a way to measure this)
I don't know how to measure something like this.