License date round up cause confusion
Summary
When a license is uploaded to a GitLab instance, the license page will show information of the license including the license Expires
date. However, it the number is rounded up in a weird way.
If the license is multiple years, at the start of the license term it will be rounded "down" to the lower year number.
Steps to reproduce
- Upload a 2 years license to a GitLab instance
- Navigate to
Admin Area → License
- In license detail,
Expires: in 1 year
which could be confusing to customer
Example Project
What is the current bug behavior?
License detail shows expire duration rounded "down".
What is the expected correct behavior?
License detail shows accurate expire duration without having to hover mouse over.
Relevant logs and/or screenshots
Output of checks
GitLab 13.3.6-ee
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)