[Feature flag] Enable push_mirror_syncs_lfs
What
Remove the :push_mirror_syncs_lfs
feature flag introduced in !40137 (diffs)
Owners
- Team: groupsource code
- Most appropriate slack channel to reach out to:
#g_create_source-code-be
- Best individual to reach out to:
@nick.thomas
or@kerrizor
Expectations
What are we expecting to happen?
The feature flag allows LFS to be synced by push mirrors (e.g. UpdateRemoteMirrorWorker
). When a push mirror is configured, we'll attempt to send any LFS objects to the remote.
What might happen if this goes wrong?
At worst, this might break an individual push mirror. Given a really serious performance degradation, we might see other push mirrors getting delayed as a result.
What can we monitor to detect problems with this?
Beta groups/projects
We use push mirroring as part of the release process, so we can test with:
-
nick.thomas/test-i18n
project (->github.com/lupine/test-i18n
) -
gitlab-org/gitlab
project -
gitlab-org
/gitlab-com
groups
Roll Out Steps
-
Enable on staging -
Test on staging -
Ensure that documentation has been updated !44457 (merged) -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry !44457 (merged) -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Edited by Nick Thomas