Sign in or sign up before continuing. Don't have an account yet? Register now to get started.
Register now

Liveness check returns OK for Gitaly when service down

Summary

Liveness check returns OK for Gitaly when service down

Steps to reproduce

Run commands:

sudo gitlab-ctl stop gitaly
curl -Lk https://localhost/-/liveness

Example Project

What is the current bug behavior?

Output of console commands:

root@gitlab-ee-latest:~# sudo gitlab-ctl status gitaly
down: gitaly: 35s, normally up; run: log: (pid 1493) 8702848s

root@gitlab-ee-latest:~# curl -Lk https://localhost/-/liveness
{"db_check":{"status":"ok"},"redis_check":{"status":"ok"},"cache_check":{"status":"ok"},"queues_check":{"status":"ok"},"shared_state_check":{"status":"ok"},"gitaly_check":{"status":"ok"}}

root@gitlab-ee-latest:~# 

What is the expected correct behavior?

Gitaly status should return as "down".

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Results of GitLab application Check

Possible fixes

Edited Nov 22, 2018 by Adam Mulvany
Assignee Loading
Time tracking Loading