Request resolved discussions incrementally in the merge request interface

Problem to solve

Loading merge requests with lots of discussions is very slow. It is painful for us every month working on the release post and painful for customers reviewing complex merge requests too! One problem is that we load all the discussions in one request, which is potentially hundred of discussions at once.

It would probably be faster to load less data in the first request.

Further details

It is not so simply to avoid the page jumping around as more data is loaded because we order commits from oldest to newest. But resolved discussions are automatically collapsed. We can exclude a lot of this data from first load.

Proposal

Exclude most data relating to resolved discussions from first load, then load once rendered.

Links / references

Edited Nov 20, 2018 by James Ramsay (ex-GitLab)
Assignee Loading
Time tracking Loading