Interpretation of AD Password - truncates everything after first '#' character

Summary

If the ad password provided in /etc/gitlab/gitlab.rb contains more than one '#' character everything including the second one gets truncated in the resulting /var/opt/gitlab/gitlab-rails/etc/gitlab.yml.

Steps to reproduce

Using a password that contains one or more '#' characters then the truncation will occur after the first '#' character.

Example Project

n/a

What is the current bug behavior?

See "Steps to reproduce" above.

What is the expected correct behavior?

The '#' character should be accepted as part of the ad password and not truncated after the fisrt '#' character.

Relevant logs and/or screenshots

n/a

Output of checks

This is on a self-hosted GitLab instance.

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

My workaround is to edit /var/opt/gitlab/gitlab-rails/etc/gitlab.yml after a gitlab-ctl reconfigure to add the missing part of the password and then do a gitlab-ctl restart to pick it up.

Assignee Loading
Time tracking Loading