Clarifying what 0 required approvals means

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Problem to solve

When adding a new approval rule, the Approvals required can be set to 0 and the implications of that are not specified in the UI.

Proposal

Stating that in the UI is a good small step to clarify that. When a user sets the Approvers required field to 0, then show a warning message

Approval not required for a merge request. Learn more.

Before	After

What does success look like?

Users should be able to identify when an approval rule is optional.

Documentation

• https://docs.gitlab.com/ee/user/project/merge_requests/approvals/rules.html#add-an-approval-rule
• https://docs.gitlab.com/ee/user/project/merge_requests/approvals/index.html#optional-approvals