Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,829
    • Issues 34,829
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,216
    • Merge Requests 1,216
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #249170

Closed
Open
Opened Sep 14, 2020 by Dan Davison@ddavisonMaintainer

[QA] Add explicit waiting to each interaction method

Problem to solve

To assist with testability and improve reliability of the test framework, we should have an explicit wait attached to each interaction method.

Proposal

Override the find_element() method with a built-in explicit wait to ensure the element appears before any interaction.

def find_element(element)
  wait_until(sleep_interval: 1, reload: false) do
    has_element? element
  end  
end

Then have any method that refers to an interaction click, fill, check, uncheck, select - call find_element ensuring that the element exists before attempting to perform the action.

Adding a "wait until element present" to find_element is appropriate, too, since calling this would mean our test would expect the element to appear.

Edited Sep 14, 2020 by Dan Davison
Assignee
Assign to
13.8
Milestone
13.8 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab#249170