Fix sentence splitting in Gitpod message (Gitpod Follow-up)
Context
The following discussion from !37985 (merged) should be addressed:
-
@pslaughter started a discussion: suggestion (non-blocking): According to our i18n docs:
Please never split a sentence as that would assume the sentence grammar and structure is the same in all languages.
For this reason, we usually have a
link_start
andlink_end
(instead of justlink
) variables for these interpolated translated strings.s_('Enable %{link_start}Gitpod%{link_end} integration to launch a development environment in your browser directly from GitLab.')
While we're at it, I see that we have this same paragraph/message in the user preference settings as well. It might be nice to move all of this to some sort of
gitpod_description
method in a helper module.We can take care of this in a follow-up
😄
Occurrences:
app/views/admin/application_settings/_gitpod.html.haml:3
app/views/profiles/preferences/_gitpod.html.haml:1
app/views/shared/gitpod/_enable_gitpod_modal.html.haml:9
Edited by Paul Slaughter