Follow-up from "Resolve "Create new group: Rename form fields and update UI""
Background
The following discussion from gitlab-ce!22418 should be addressed:
-
@dennis started a discussion: Do we have an issue to track the remaining views that are using
old_visibility_level
?Not relevant to this MR, but would be nice to create one to make sure we get rid of the old view whenever that may happen.
Proposal
Remove app/views/shared/_old_visibility_level.html.haml
HAML partial and replace with app/views/shared/_visibility_level.html.haml
.
Implementation guide
- In app/views/admin/groups/_form.html.haml#L14 replace
shared/old_visibility_level
withshared/visibility_level
. - Remove
app/views/shared/_old_visibility_level.html.haml
HAML partial - Go to
/admin/groups
and clickEdit
next to a group. - Verify the visibility level radio buttons look and function correctly.
- Take before and after screenshots and post in MR description.
Edited by Peter Hegman