Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,289
    • Issues 44,289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,284
    • Merge requests 1,284
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #247486
Closed
Open
Issue created Sep 10, 2020 by Miguel Rincon@mrincon🚀Maintainer0 of 15 checklist items completed0/15 checklist items

[Feature flag] Enable Pipeline Triggers settings port to Vue

What

In #250312 (closed) we delivered a change to rewrite the Pipeline Triggers table in Vue (MR !41864 (merged))

The goal of this rollout issue is to ensure the Vue port works as the previous version and then remove the previous version.

Remove the :ci_pipeline_triggers_settings_vue_ui feature flag.

Cleanup notes:

Owners

  • Team: ~"group::continuous integration"
  • Most appropriate slack channel to reach out to: #g_ci
  • Best individual to reach out to: @mrincon

Expectations

What are we expecting to happen?

What might happen if this goes wrong?

What can we monitor to detect problems with this?

Beta groups/projects

If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.

  • gitlab-org/gitlab project
  • gitlab-org/gitlab-com groups
  • ...

Roll Out Steps

  • Enable on staging
  • Test on staging
  • Ensure that documentation has been updated
  • Enable on GitLab.com for individual groups/projects listed above and verify behaviour
  • Coordinate a time to enable the flag with #production and #g_delivery on slack.
  • Clean up old code (non-exhaustive list)
    • app/presenters/ci/trigger_presenter.rb (full removal)
    • spec/features/triggers_spec.rb (remove old tests)
    • Remove @triggers from app/controllers/projects/settings/ci_cd_controller.rb
  • Announce on the issue an estimated time this will be enabled on GitLab.com
  • Enable on GitLab.com by running chatops command in #production
  • Cross post chatops slack command to #support_gitlab-com (more guidance when this is necessary in the dev docs) and in your team channel
  • Announce on the issue that the flag has been enabled
  • Remove feature flag and add changelog entry
  • After the flag removal is deployed, clean up the feature flag by running chatops command in #production channel
Edited Nov 19, 2020 by Miguel Rincon
Assignee
Assign to
Time tracking