Fragile migration spec
I have an MR that adds a new column to the namespaces
table which breaks https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/lib/gitlab/background_migration/user_mentions/create_resource_user_mention_spec.rb .
The spec seems to initialize an old schema. Because the schema is not the latest, my column does not exist so when it's called indirectly by this spec it fails.
I currently have a work around in place !36025 (diffs), but I don't think it's appropriate to leave there forever just to appease this spec.
There was a discussion on Slack. The conclusion was:
- If the migration is needed later, we may as well fix the spec
- The migration may not be needed in it's current form, in which case just remove for now to unblock