Clean up code in Mutations::Security::CiConfiguration
Summary
We need to refactor some work related to our SAST Config UI.
In Convert to actual GraphQL types, we added code that allowed us to implement a new, compliant API for the GraphQL mutation, while supporting the existing (and different) API for the REST POST. The frontend is currently using the REST endpoint.
After the frontend switches to using the GraphQL mutation, the REST POST and the #format_for_service
method will be removed from Mutations::Security::CiConfiguration::ConfigureSast
, and Security::CiConfiguration::SastCreateService
will be refactored.
Improvements
- Remove the
#create
action of sast_configuration_controller.rb and all the related code in the controller. - Remove the route for the create action
- Remove any related specs for the create action
- Remove the early return from the
#variables
method in Security::CiConfiguration::SastBuildActions
Risks
This will cause problems if we remove the REST POST endpoint while it is still being used.
Involved components
Optional: Intended side effects
Optional: Missing test coverage
Edited by rossfuhrman