Notes (comments) API not listing "labels" changes
Summary
I'm using GitLab Community Edition 11.3.4 gitlab-ce@30f019dca78bb64bcb8b355a267be006884e6d8f
When invoking this command:
GET /projects/:id/issues/:issue_iid/notes
I used to get all Notes (comments) for the given Issue. Some of them could be "system" notes (such as "assigned to {username}"), others could be "user" notes (actual comments).
Since the last update I can no longer get system=true
notes about labels changes, such as "{username} added {label_id} and removed {label_id}".
My application actually started to return incomplete results because of this.
Is it a desired feature?
Steps to reproduce
I have a test issue. Accessing it from the webpage of GitLab CE it contains these notes:
- One comment written by me with my username
- One system note "{username} removed {LABEL}"
- This one was generated by an action performed directly on GitLab
- One system note "{username} removed {LABEL}"
- This one was generated by an API call
- One system note "assigned to {username}"
- This one was generated by an API call
- One system note "assigned to {another_username} and unassigned {username}"
- This one was generated by an action performed directly on GitLab
API call:
GET /projects/:id/issues/:issue_iid/notes
I can get just 3 notes:
- My comment
- System note "assigned to {username}"
- System note "assigned to {another_username} and unassigned {username}"
What is the current bug behavior?
Notes API call returns all notes (both system=true
and system=false
) except the system=true
notes about labels changes.
What is the expected correct behavior?
Notes API call returns all notes, including the ones about labels additions and removals.
Results of GitLab environment info
gitlab-rake gitlab:env:info
System information System: Debian 9.5 Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.18.1 Sidekiq Version:5.1.3 Go Version: unknownGitLab information Version: 11.3.4 Revision: 30f019d Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.********* HTTP Clone URL: https://gitlab./some-group/some-project.git SSH Clone URL: git@gitlab.:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 8.3.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
gitlab-rake gitlab:check SANITIZE=true
Checking GitLab Shell ...GitLab Shell version >= 8.3.3 ? ... OK (8.3.3) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 2/1 ... ok 2/4 ... ok 2/5 ... ok 2/6 ... ok 2/7 ... ok 9/8 ... ok 9/9 ... ok 9/10 ... ok 9/11 ... ok 3/12 ... ok 2/13 ... ok 2/14 ... ok 2/15 ... ok 12/16 ... ok 13/18 ... ok 13/19 ... ok 14/20 ... ok 2/21 ... ok 13/22 ... ok 13/25 ... ok 13/26 ... ok 13/27 ... ok 13/28 ... ok 13/29 ... ok 13/30 ... ok 13/31 ... ok 13/32 ... ok 13/33 ... ok 13/34 ... ok 2/35 ... ok 13/36 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... no Try fixing it: sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ; sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ; For more information see: doc/install/installation.md in section "GitLab" Please fix the error above and rerun the checks. Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 2/4 ... yes 2/5 ... yes 2/6 ... yes 2/7 ... yes 9/8 ... yes 9/9 ... yes 9/10 ... yes 9/11 ... yes 3/12 ... yes 2/13 ... yes 2/14 ... yes 2/15 ... yes 12/16 ... yes 13/18 ... yes 13/19 ... yes 14/20 ... yes 2/21 ... yes 13/22 ... yes 13/25 ... yes 13/26 ... yes 13/27 ... yes 13/28 ... yes 13/29 ... yes 13/30 ... yes 13/31 ... yes 13/32 ... yes 13/33 ... yes 13/34 ... yes 2/35 ... yes 13/36 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 12
Checking GitLab ... Finished