Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,763
    • Issues 44,763
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,330
    • Merge requests 1,330
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #24614
Closed
Open
Issue created Oct 09, 2018 by Antony Saba@asaba🚨Contributor

Prevent users from using known insecure public key

Problem to solve

Users are able to upload known insecure or otherwise shared SSH keys. This results in unintended access across users and projects.

Further details

Recently, User A uploaded a known bad key, which resulted in allowing access by other users to User As repository due the shared private key being present in the environment of the other users. Protecting the integrity of user data is priority of GitLab and especially on GitLab.com.

Previous internal GitLab discussion: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/5229

I am creating a new issue here that can be made public.

Proposal

For an MVC, create a hardcoded list of public SSH keys that users will be prevented from using, starting with list like that provided by https://github.com/rapid7/ssh-badkeys.

What does success look like, and how can we measure that?

When trying to upload a known bad public key, user is shown a similar message to when another user has already associated the key with their account.

Links / references

I am assigning gitlab-ce3713901 / gitlab-ce3857529 as this affects the integrity of user repositories.

Assignee
Assign to
Time tracking