Prevent users from entering negative number of replicas in Advanced Search settings

Summary

In Elasticsearch Integration setting it is possible to select a negative number from the UI slider, on saving the configuration you are presented with a warning.

Elasticsearch replicas must be greater than or equal to 0

Steps to reproduce

  • Go to admin/application_settings/general#js-elasticsearch-settings
  • Number of Elasticsearch replicas
  • Select a negative number
  • Save

What is the current bug behavior?

Warning is displayed and setting are unsaved.

What is the expected correct behavior?

Unable to select a negative number would negate the warning.

Relevant logs and/or screenshots

Screen_Shot_2020-09-04_at_4.52.14_pm

Output of checks

Results of GitLab environment info

In latest version as at 13.3.4

Results of GitLab application Check

Possible fixes