Follow-up from "Keep IDE RightPane views alive"
Description
The following discussion from gitlab-ce!21980 should be addressed:
-
@pslaughter started a discussion: (+3 comments) Would it make the logic simpler if we just kept all of the sidebars alive?
🤔 This was my original intent. Unfortunately some views are not in a position where this is possible.
Safe to keep alive:
-
merge-request-infosimply presents some Vuex state, so it is safe to keep alive. -
pipelinesinitializes a polling routine on mount, which is safe to keep alive.
Not safe to keep alive:
-
jobs-detailfetchesgetTrace()on mount, which is based on the currently selected job. If this views was kept alive, but the job changed, it will still show the old trace. Also, (for some unknown reason) this view seems to blow up when it is kept alive but not active.🤷 -
clientsidesimilarly, this component initializes on mount based on the current files.
WDYT, of creating an issue to address the not safe components, with the intention of keeping all the sidebars alive?
-