An error occurred while fetching the assigned iteration of the selected issue.
Optimize rendering calls in HipchatService
At https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/project_services/hipchat_service.rb#L148 of the HipchatService
, we call Banzai.render(text, context)
, and then a few lines later call html = Banzai.post_process(Banzai.render(text, context), context)
This seems redundant and unnecessary. However we want to be careful not to incorrectly change the behavior.
Please review the initial discussion on it here: https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2507#note_135023