Help icons should not toggle checkbox
Summary
This is a follow-up issue from https://gitlab.com/gitlab-org/gitlab-ce/issues/51476
This issue occurs on the following pages:
| Page | |
|---|---|
| Group Settings (Permissions) |  |
| Auto DevOps (Project Settings - CI/CD) |  |
What is the current bug behavior?
The click events on the info icon toggles the checkbox.
What is the expected correct behavior?
Clicking the info-icon shouldn't toggle the checkbox.
Possible fixes
The issue only appears when the <a> info icon is nested within the <label> tag.
A potential fix would be to rearrange the HAML template, in order to have the checkbox and the label to appear on the same level (instead of having nested elements). Additionally, a wrapping div with the .checkbox-icon-inline-wrapper class should be added, see https://gitlab.com/gitlab-org/gitlab-ce/blob/df53c035c98c6d5cd3fbbfe0582df4ebcaf535f7/app/views/profiles/show.html.haml#L112
Edited by 🤖 GitLab Bot 🤖