org with "." causes invalid certificate with some pages

Summary

trying to view items that are hosted on pages (.gitlab.com for example) doesn't work properly with organization has a period in it.

Steps to reproduce

Create an organization 'example.tld'. Create a repo in that org/group Create a CI workflow that creates an artifact containing a index.html Make changes that cause this CI workflow to be run Find job in the CI section, and select the "browse" button to inspect the artifact it should send you to https://gitlab.com/example.tld/reponame/-/jobs//artifacts/browse click the directories needed to get to the file to view it When you click on the index.html after browsing, it should send you to https://gitlab.com/example.tld/reponame/-/jobs//artifacts/file//index.html and opening that link will redirect to https://example.tld.gitlab.com/-/reponame/-/jobs//artifacts/file//index.html

this latter link will fail because the certificate used only matches *.gitlab.com.

Example Project

What is the current bug behavior?

ssl net::err_cert_common_name_invalid

What is the expected correct behavior?

no SSL warnings

Relevant logs and/or screenshots

n/a

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

the bug will manifest if the organization contains a period. (DNS name used <org.tld.gitlab.com> will not match *.gitlab.com)

Results of GitLab application Check

N/A

Possible fixes

Do not allow organization to be created with a period inside the name (or names that are not dns-compatible) (Not sure how to handle existing organization without breaking other things like links to previous items, etc)

Edited by Jok Thuau