Jira Integration: settings are not persisted

Summary

Jira integration: configuration is not saved when creating it in disabled state.

Steps to reproduce

With gitlab-ce:13.3.1-ce.0, when creating a new Jira Integration for a project, I create a disabled Jira integration by filling out the form (URL, user, password).

I get the feedback "JIRA settings saved, but not activated."

What is the current bug behavior?

The form is now empty. When looking into the database:

select properties from services where type = 'JiraService' and project_id = 659;
 properties 
------------
 {}
(1 row)

So the configuration is not saved in the database.

What is the expected correct behavior?

The form should contain the data I just entered, and it should be persisted in the database.

Relevant logs and/or screenshots

Started PUT "/myuser/myproject/-/services/jira" for 127.0.0.1 at 2020-08-28 19:37:28 +0000                                                                                   
Processing by Projects::ServicesController#update as HTML                                                                                                                                     
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "service"=>{"active"=>"false", "commit_events"=>"true", "merge_requests_events"=>"true", "comment_on_event_enabled"=>"true", "
url"=>"https://myjiraserver", "api_url"=>"", "username"=>"myjirauser", "password"=>"[FILTERED]", "jira_issue_transition_id"=>""}, "redirect_to"=>"https://mygitlabserver/myuser
/myproject/-/settings/integrations", "namespace_id"=>"myuser", "project_id"=>"myproject", "id"=>"jira"}                                                           
Redirected to https://mygitlabserver/myuser/myproject/-/services/jira/edit               

Results of GitLab environment info

GitLab13.3.1 (d54b96a3079)

Output of gitlab:env:info

System information
System:
Current User:   git
Using RVM:      no
Ruby Version:   2.6.6p146
Gem Version:    2.7.10
Bundler Version:1.17.3
Rake Version:   12.3.3
Redis Version:  5.0.9
Git Version:    2.28.0
Sidekiq Version:5.2.9
Go Version:     unknown
GitLab information
Version:        13.3.1
Revision:       d54b96a3079
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     11.7
URL:            https://git.gentics.com
HTTP Clone URL: https://git.gentics.com/some-group/some-project.git
SSH Clone URL:  git@git.gentics.com:some-group/some-project.git
Using LDAP:     yes
Using Omniauth: yes
Omniauth Providers:
GitLab Shell
Version:        13.6.0
Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Output of gitlab-rake gitlab:check SANITIZE=true

Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 13.6.0 ? ... OK (13.6.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
User output sanitized. Found 73 users of 100 limit.
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
4/1 ... yes
4/2 ... yes
4/3 ... yes
4/4 ... yes
6/6 ... yes
4/7 ... yes
4/8 ... yes
4/9 ... yes
6/10 ... yes
4/11 ... yes
6/12 ... yes
4/13 ... yes
4/14 ... yes
4/16 ... yes
4/17 ... yes
4/18 ... yes
4/19 ... yes
4/20 ... yes
4/21 ... yes
4/22 ... yes
4/23 ... yes
4/25 ... yes
4/26 ... yes
4/27 ... yes
4/28 ... yes
4/30 ... yes
4/31 ... yes
4/32 ... yes
4/33 ... yes
4/34 ... yes
6/35 ... yes
4/36 ... yes
4/37 ... yes
4/38 ... yes
3/41 ... yes
4/42 ... yes
4/44 ... yes
4/46 ... yes
4/47 ... yes
4/50 ... yes
4/51 ... yes
42/52 ... yes
41/55 ... yes
35/57 ... yes
4/58 ... yes
4/59 ... yes
36/63 ... yes
136/64 ... yes
4/66 ... yes
4/67 ... yes
4/71 ... yes
4/72 ... yes
4/75 ... yes
4/77 ... yes
4/78 ... yes
36/79 ... yes
4/80 ... yes
4/83 ... yes
4/84 ... yes
2/85 ... yes
3/86 ... yes
35/87 ... yes
16/88 ... yes
3/89 ... yes
4/90 ... yes
4/91 ... yes
4/92 ... yes
4/93 ... yes
4/96 ... yes
58/98 ... yes
58/99 ... yes
4/100 ... yes
4/101 ... yes
41/106 ... yes
4/107 ... yes
4/108 ... yes
47/109 ... yes
4/110 ... yes
4/111 ... yes
41/112 ... yes
51/113 ... yes
42/114 ... yes
4/115 ... yes
51/116 ... yes
4/117 ... yes
4/118 ... yes
4/119 ... yes
4/120 ... yes
4/121 ... yes
4/122 ... yes
4/123 ... yes
4/124 ... yes
4/125 ... yes
3/126 ... yes
41/127 ... yes
4/132 ... yes
4/133 ... yes
4/136 ... yes
4/137 ... yes
4/139 ... yes
4/140 ... yes
4/141 ... yes
4/142 ... yes
4/143 ... yes
4/144 ... yes
65/145 ... yes
4/146 ... yes
4/147 ... yes
4/148 ... yes
4/149 ... yes
136/150 ... yes
4/152 ... yes
4/153 ... yes
4/154 ... yes
4/155 ... yes
4/156 ... yes
4/157 ... yes
136/158 ... yes
136/161 ... yes
136/162 ... yes
4/163 ... yes
136/165 ... yes
136/166 ... yes
4/167 ... yes
4/168 ... yes
136/169 ... yes
136/170 ... yes
136/171 ... yes
136/172 ... yes
136/173 ... yes
4/174 ... yes
136/175 ... yes
136/176 ... yes
136/177 ... yes
136/178 ... yes
136/179 ... yes
51/180 ... yes
4/181 ... yes
4/183 ... yes
4/184 ... yes
136/185 ... yes
4/186 ... yes
136/187 ... yes
136/188 ... yes
4/190 ... yes
4/191 ... yes
136/192 ... yes
136/193 ... yes
136/194 ... yes
136/195 ... yes
136/196 ... yes
4/197 ... yes
4/198 ... yes
4/199 ... yes
4/200 ... yes
4/201 ... yes
69/204 ... yes
4/205 ... yes
71/207 ... yes
4/208 ... yes
4/210 ... yes
4/211 ... yes
4/212 ... yes
4/214 ... yes
4/215 ... yes
4/216 ... yes
4/217 ... yes
4/218 ... yes
4/220 ... yes
4/221 ... yes
4/222 ... yes
4/223 ... yes
4/225 ... yes
51/226 ... yes
4/227 ... yes
4/228 ... yes
4/229 ... yes
4/230 ... yes
37/231 ... yes
4/232 ... yes
4/233 ... yes
4/234 ... yes
4/236 ... yes
4/237 ... yes
84/238 ... yes
4/239 ... yes
37/240 ... yes
4/242 ... yes
4/243 ... yes
4/244 ... yes
51/245 ... yes
4/246 ... yes
4/247 ... yes
4/248 ... yes
4/249 ... yes
4/250 ... yes
4/251 ... yes
4/253 ... yes
4/255 ... yes
4/256 ... yes
83/257 ... yes
4/260 ... yes
4/261 ... yes
51/262 ... yes
4/264 ... yes
4/265 ... yes
141/266 ... yes
4/267 ... yes
4/268 ... yes
4/269 ... yes
4/270 ... yes
4/271 ... yes
4/273 ... yes
4/274 ... yes
4/275 ... yes
4/277 ... yes
4/281 ... yes
37/282 ... yes
4/285 ... yes
4/286 ... yes
4/287 ... yes
4/289 ... yes
93/290 ... yes
4/292 ... yes
4/293 ... yes
4/294 ... yes
4/295 ... yes
69/296 ... yes
4/297 ... yes
4/298 ... yes
4/300 ... yes
83/301 ... yes
4/302 ... yes
4/303 ... yes
84/304 ... yes
4/305 ... yes
4/307 ... yes
4/308 ... yes
4/309 ... yes
4/310 ... yes
69/311 ... yes
4/313 ... yes
4/314 ... yes
69/315 ... yes
4/316 ... yes
4/317 ... yes
4/321 ... yes
4/332 ... yes
95/333 ... yes
4/334 ... yes
4/335 ... yes
93/336 ... yes
4/337 ... yes
4/338 ... yes
4/339 ... yes
4/340 ... yes
93/342 ... yes
4/343 ... yes
4/344 ... yes
4/347 ... yes
4/349 ... yes
4/350 ... yes
4/351 ... yes
4/352 ... yes
4/353 ... yes
4/354 ... yes
4/355 ... yes
4/356 ... yes
4/357 ... yes
4/359 ... yes
4/360 ... yes
4/361 ... yes
4/362 ... yes
4/363 ... yes
4/364 ... yes
4/365 ... yes
4/366 ... yes
4/367 ... yes
4/368 ... yes
4/370 ... yes
4/371 ... yes
99/372 ... yes
4/373 ... yes
4/374 ... yes
84/375 ... yes
4/376 ... yes
4/377 ... yes
4/378 ... yes
4/379 ... yes
4/380 ... yes
4/381 ... yes
4/382 ... yes
4/383 ... yes
4/384 ... yes
4/385 ... yes
4/387 ... yes
4/388 ... yes
4/389 ... yes
4/390 ... yes
69/391 ... yes
4/392 ... yes
4/394 ... yes
4/395 ... yes
4/396 ... yes
4/397 ... yes
4/399 ... yes
4/401 ... yes
4/402 ... yes
4/403 ... yes
4/404 ... yes
4/405 ... yes
4/406 ... yes
4/407 ... yes
4/408 ... yes
84/409 ... yes
4/410 ... yes
4/411 ... yes
4/412 ... yes
4/413 ... yes
4/414 ... yes
4/416 ... yes
4/419 ... yes
69/420 ... yes
4/421 ... yes
4/422 ... yes
93/423 ... yes
4/424 ... yes
4/425 ... yes
4/426 ... yes
4/428 ... yes
4/430 ... yes
4/431 ... yes
4/432 ... yes
136/433 ... yes
4/434 ... yes
4/435 ... yes
4/436 ... yes
4/439 ... yes
4/440 ... yes
4/441 ... yes
4/442 ... yes
4/443 ... yes
87/444 ... yes
4/445 ... yes
4/446 ... yes
4/447 ... yes
16/448 ... yes
4/449 ... yes
4/450 ... yes
4/451 ... yes
83/452 ... yes
4/453 ... yes
51/454 ... yes
4/455 ... yes
4/456 ... yes
4/457 ... yes
4/458 ... yes
4/459 ... yes
4/460 ... yes
4/461 ... yes
4/462 ... yes
84/463 ... yes
4/464 ... yes
4/466 ... yes
4/467 ... yes
84/468 ... yes
4/469 ... yes
4/470 ... yes
4/472 ... yes
4/473 ... yes
17/474 ... yes
4/475 ... yes
87/476 ... yes
4/477 ... yes
4/478 ... yes
4/479 ... yes
4/480 ... yes
4/481 ... yes
4/482 ... yes
123/483 ... yes
4/484 ... yes
84/485 ... yes
136/486 ... yes
4/487 ... yes
4/488 ... yes
4/489 ... yes
4/490 ... yes
84/491 ... yes
4/492 ... yes
4/493 ... yes
4/494 ... yes
4/495 ... yes
4/496 ... yes
84/497 ... yes
4/498 ... yes
104/499 ... yes
4/500 ... yes
4/501 ... yes
4/502 ... yes
141/504 ... yes
141/505 ... yes
4/506 ... yes
141/507 ... yes
4/508 ... yes
4/509 ... yes
4/510 ... yes
4/511 ... yes
4/512 ... yes
4/513 ... yes
4/514 ... yes
4/515 ... yes
154/516 ... yes
141/517 ... yes
141/518 ... yes
4/519 ... yes
4/522 ... yes
4/524 ... yes
84/525 ... yes
4/526 ... yes
4/527 ... yes
136/528 ... yes
4/529 ... yes
4/530 ... yes
4/531 ... yes
4/532 ... yes
63/533 ... yes
4/534 ... yes
4/535 ... yes
4/536 ... yes
4/537 ... yes
4/538 ... yes
141/539 ... yes
4/540 ... yes
4/541 ... yes
4/542 ... yes
4/543 ... yes
84/544 ... yes
4/545 ... yes
51/546 ... yes
157/547 ... yes
157/549 ... yes
4/550 ... yes
157/551 ... yes
4/552 ... yes
4/555 ... yes
4/556 ... yes
4/557 ... yes
4/558 ... yes
4/559 ... yes
4/560 ... yes
4/561 ... yes
4/562 ... yes
4/563 ... yes
4/564 ... yes
4/565 ... yes
69/566 ... yes
84/568 ... yes
4/569 ... yes
4/570 ... yes
4/571 ... yes
165/572 ... yes
71/573 ... yes
4/574 ... yes
4/575 ... yes
4/577 ... yes
4/578 ... yes
69/579 ... yes
4/580 ... yes
166/582 ... yes
4/583 ... yes
4/584 ... yes
4/585 ... yes
173/586 ... yes
166/587 ... yes
4/588 ... yes
4/589 ... yes
158/590 ... yes
4/591 ... yes
158/592 ... yes
141/593 ... yes
4/594 ... yes
157/595 ... yes
166/596 ... yes
141/597 ... yes
177/598 ... yes
4/599 ... yes
4/600 ... yes
4/601 ... yes
84/602 ... yes
166/603 ... yes
141/605 ... yes
69/606 ... yes
4/607 ... yes
141/608 ... yes
175/609 ... yes
158/610 ... yes
158/611 ... yes
4/612 ... yes
4/613 ... yes
157/614 ... yes
4/615 ... yes
165/616 ... yes
165/617 ... yes
165/618 ... yes
4/620 ... yes
4/621 ... yes
4/622 ... yes
165/625 ... yes
179/626 ... yes
4/627 ... yes
184/628 ... yes
4/629 ... yes
165/630 ... yes
185/631 ... yes
4/632 ... yes
185/633 ... yes
141/634 ... yes
157/635 ... yes
141/636 ... yes
185/638 ... yes
157/639 ... yes
185/640 ... yes
141/641 ... yes
177/642 ... yes
4/643 ... yes
4/644 ... yes
185/645 ... yes
166/646 ... yes
185/647 ... yes
185/649 ... yes
150/650 ... yes
150/651 ... yes
150/652 ... yes
4/653 ... yes
190/654 ... yes
141/655 ... yes
141/656 ... yes
190/657 ... yes
141/658 ... yes
166/659 ... yes
4/661 ... yes
193/662 ... yes
141/663 ... yes
83/665 ... yes
195/666 ... yes
157/667 ... yes
198/670 ... yes
4/671 ... yes
175/672 ... yes
4/673 ... yes
4/674 ... yes
141/675 ... yes
198/676 ... yes
4/677 ... yes
166/678 ... yes
185/679 ... yes
4/680 ... yes
193/681 ... yes
141/682 ... yes
4/683 ... yes
4/684 ... yes
4/685 ... yes
185/686 ... yes
193/687 ... yes
4/688 ... yes
141/689 ... yes
193/690 ... yes
4/691 ... yes
158/692 ... yes
198/693 ... yes
190/694 ... yes
198/695 ... yes
190/696 ... yes
198/697 ... yes
141/698 ... yes
190/699 ... yes
190/700 ... yes
136/701 ... yes
190/702 ... yes
198/703 ... yes
Redis version >= 4.0.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.6)
Git version >= 2.24.0 ? ... yes (2.28.0)
Git user has default SSH configuration? ... yes
Active users: ... 86
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... no
Try fixing it:
Please migrate all projects to hashed storage
as legacy storage is deprecated in 13.0 and support will be removed in 14.0.
For more information see:
doc/administration/repository_storage_types.md
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished