Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,767
    • Issues 44,767
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,329
    • Merge requests 1,329
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #241668
Closed
Open
Issue created Aug 27, 2020 by Michael Kozono@mkozono1️⃣Maintainer

Geo: More design sync failures in staging

Problem

After !39916 (merged), there are still DesignRepositoryUpdatedEvent being processed for Project IDs that should not be processed.

image

Possible reason

At the moment, I think this is because:

  • the MR assumes that DesignRepositoryUpdatedEvent are not created for projects that do not have designs
  • project imports create DesignRepositoryUpdatedEvent even when there are no designs https://gitlab.com/gitlab-org/gitlab/blob/v13.3.0-ee/ee/app/models/ee/project_import_state.rb#L63

Possible fixes

  1. Implement DesignRepositoryUpdatedEvent#replicable_design? instead of reusing BaseEvent#replicable_project?
  2. Check for repos before sending repo update events from import

I think we should actually do both.

Assignee
Assign to
Time tracking