Skip to content

Improve usage of variables in MergeRequest model spec

The spec for EE::MergeRequest contains top-level variables that are overrided and needs some improvements:

  • let(:project) { create(:project, :repository) } is overrided in other examples 1 2 3 and more. Concider using only top-level definition of project and also define it with let_it_be to improve performance.

  • merge_request is defined as subject but it's overrided in following examples as well 1 2 3 and more. Concider defining merge_request with let_it_be and remove top level subject.