Azure AD Login Remember Me not working

Summary

Using "Remember me" checkbox during Azure AD SSO won't auto-login after browser restart. When the checkbox is ticked, the session should be reinstantiated.

Steps to reproduce

1. Setup Azure AD SSO
2. Logout / kill all GitLab cookies
3. On the login page, tick "Remember me" and sign in via Azure AD.
   

What is the current bug behavior?

• Login via Azure AD works
• Closing the browser / killing all session cookies won't auto-login

What is the expected correct behavior?

Session should be reinstantiated from remember me cookie. No login should be necessary.

Results of GitLab environment info

Expand for output related to GitLab environment info

System information
System:         Debian 10
Current User:   git
Using RVM:      no
Ruby Version:   2.6.6p146
Gem Version:    2.7.10
Bundler Version:1.17.3
Rake Version:   12.3.3
Redis Version:  5.0.9
Git Version:    2.28.0
Sidekiq Version:5.2.9
Go Version:     unknown

GitLab information
Version:        13.3.0
Revision:       9119206b6e8
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     12.3
URL:            https://gitlab.redacted.de
HTTP Clone URL: https://gitlab.redacted.de/some-group/some-project.git
SSH Clone URL:  git@gitlab.redacted.de:some-group/some-project.git
Using LDAP:     no
Using Omniauth: yes
Omniauth Providers: azure_oauth2, gitlab, github, bitbucket

GitLab Shell
Version:        13.6.0
Repository storage paths:
- default:      /mnt/git-data/_data/repositories
GitLab Shell path:              /opt/gitlab/embedded/service/gitlab-shell
Git:            /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 13.6.0 ? ... OK (13.6.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
3/1 ... yes
6/4 ... yes
6/5 ... yes
13/6 ... yes
6/7 ... yes
3/9 ... yes
53/10 ... yes
7/11 ... yes
15/12 ... yes
8/14 ... yes
8/15 ... yes
7/16 ... yes
15/17 ... yes
7/19 ... yes
19/20 ... yes
15/21 ... yes
7/22 ... yes
7/23 ... yes
19/24 ... yes
19/25 ... yes
19/26 ... yes
1/27 ... yes
19/28 ... yes
7/29 ... yes
15/30 ... yes
13/31 ... yes
8/33 ... yes
8/34 ... yes
15/35 ... yes
53/38 ... yes
3/39 ... yes
22/40 ... yes
13/41 ... yes
13/42 ... yes
10/44 ... yes
13/46 ... yes
13/47 ... yes
19/48 ... yes
22/49 ... yes
13/50 ... yes
22/51 ... yes
22/54 ... yes
34/56 ... yes
22/57 ... yes
7/58 ... yes
53/59 ... yes
34/60 ... yes
13/61 ... yes
13/62 ... yes
13/63 ... yes
34/64 ... yes
7/65 ... yes
1/67 ... yes
3/68 ... yes
7/69 ... yes
6/70 ... yes
7/71 ... yes
7/72 ... yes
25/73 ... yes
18/74 ... yes
25/75 ... yes
26/76 ... yes
7/77 ... yes
7/78 ... yes
7/79 ... yes
43/80 ... yes
1/81 ... yes
7/82 ... yes
7/83 ... yes
26/84 ... yes
25/85 ... yes
9/86 ... yes
26/87 ... yes
1/88 ... yes
19/89 ... yes
13/90 ... yes
19/92 ... yes
19/93 ... yes
16/94 ... yes
13/95 ... yes
19/96 ... yes
13/97 ... yes
15/98 ... yes
15/99 ... yes
26/100 ... yes
25/103 ... yes
13/104 ... yes
35/105 ... yes
35/106 ... yes
15/107 ... yes
15/108 ... yes
35/109 ... yes
35/110 ... yes
7/111 ... yes
1/112 ... yes
36/113 ... yes
25/114 ... yes
7/115 ... yes
19/116 ... yes
37/117 ... yes
76/118 ... yes
37/119 ... yes
9/120 ... yes
35/121 ... yes
35/122 ... yes
18/123 ... yes
9/124 ... yes
37/125 ... yes
3/126 ... yes
19/127 ... yes
40/128 ... yes
39/129 ... yes
39/130 ... yes
25/131 ... yes
16/132 ... yes
9/133 ... yes
3/134 ... yes
35/135 ... yes
35/136 ... yes
35/137 ... yes
35/138 ... yes
35/139 ... yes
35/140 ... yes
35/141 ... yes
35/142 ... yes
35/143 ... yes
35/144 ... yes
35/145 ... yes
35/146 ... yes
35/147 ... yes
35/148 ... yes
35/149 ... yes
35/150 ... yes
35/151 ... yes
35/152 ... yes
35/153 ... yes
35/154 ... yes
35/155 ... yes
35/156 ... yes
35/157 ... yes
35/158 ... yes
35/159 ... yes
35/160 ... yes
35/161 ... yes
35/162 ... yes
35/163 ... yes
35/164 ... yes
35/165 ... yes
35/166 ... yes
35/167 ... yes
35/168 ... yes
13/169 ... yes
35/170 ... yes
3/171 ... yes
3/172 ... yes
18/173 ... yes
40/175 ... yes
37/176 ... yes
40/177 ... yes
35/178 ... yes
35/179 ... yes
76/180 ... yes
35/181 ... yes
3/182 ... yes
54/183 ... yes
35/184 ... yes
35/185 ... yes
43/186 ... yes
35/187 ... yes
18/188 ... yes
19/189 ... yes
35/190 ... yes
19/191 ... yes
35/192 ... yes
34/193 ... yes
25/194 ... yes
35/195 ... yes
35/196 ... yes
35/197 ... yes
35/198 ... yes
3/199 ... yes
35/200 ... yes
18/201 ... yes
25/202 ... yes
18/203 ... yes
18/204 ... yes
18/205 ... yes
35/206 ... yes
37/207 ... yes
49/208 ... yes
49/209 ... yes
43/210 ... yes
43/211 ... yes
25/212 ... yes
19/213 ... yes
70/214 ... yes
49/215 ... yes
50/216 ... yes
59/217 ... yes
35/218 ... yes
9/219 ... yes
15/220 ... yes
19/221 ... yes
35/222 ... yes
50/223 ... yes
19/224 ... yes
50/225 ... yes
18/226 ... yes
49/227 ... yes
50/228 ... yes
18/229 ... yes
35/230 ... yes
37/231 ... yes
37/232 ... yes
18/233 ... yes
9/234 ... yes
35/235 ... yes
9/236 ... yes
49/237 ... yes
35/238 ... yes
35/239 ... yes
15/240 ... yes
18/241 ... yes
27/242 ... yes
35/243 ... yes
51/244 ... yes
15/245 ... yes
19/246 ... yes
35/248 ... yes
13/249 ... yes
9/250 ... yes
1/251 ... yes
49/252 ... yes
49/253 ... yes
35/254 ... yes
35/255 ... yes
35/256 ... yes
35/257 ... yes
15/258 ... yes
15/259 ... yes
15/260 ... yes
35/261 ... yes
50/262 ... yes
35/263 ... yes
35/264 ... yes
35/266 ... yes
35/267 ... yes
35/268 ... yes
3/269 ... yes
49/270 ... yes
35/271 ... yes
35/272 ... yes
1/273 ... yes
35/274 ... yes
15/275 ... yes
35/276 ... yes
55/277 ... yes
3/278 ... yes
35/279 ... yes
56/280 ... yes
56/281 ... yes
56/282 ... yes
56/284 ... yes
35/285 ... yes
50/286 ... yes
35/288 ... yes
58/289 ... yes
40/290 ... yes
59/291 ... yes
56/292 ... yes
51/293 ... yes
61/294 ... yes
35/295 ... yes
3/296 ... yes
41/297 ... yes
56/298 ... yes
41/299 ... yes
35/300 ... yes
35/301 ... yes
77/302 ... yes
35/303 ... yes
35/304 ... yes
50/305 ... yes
70/306 ... yes
35/307 ... yes
35/308 ... yes
70/309 ... yes
61/310 ... yes
61/311 ... yes
61/313 ... yes
35/314 ... yes
77/315 ... yes
71/316 ... yes
54/318 ... yes
77/319 ... yes
9/320 ... yes
35/322 ... yes
73/323 ... yes
35/324 ... yes
74/325 ... yes
35/326 ... yes
35/327 ... yes
35/328 ... yes
76/329 ... yes
76/330 ... yes
76/331 ... yes
76/332 ... yes
76/333 ... yes
76/334 ... yes
76/335 ... yes
8/337 ... yes
70/338 ... yes
43/339 ... yes
49/340 ... yes
35/341 ... yes
35/342 ... yes
61/343 ... yes
61/344 ... yes
59/345 ... yes
35/346 ... yes
61/347 ... yes
18/348 ... yes
71/349 ... yes
61/350 ... yes
61/351 ... yes
26/352 ... yes
9/353 ... yes
79/354 ... yes
79/355 ... yes
94/357 ... yes
71/358 ... yes
8/359 ... yes
35/360 ... yes
8/361 ... yes
71/362 ... yes
80/363 ... yes
61/364 ... yes
74/365 ... yes
3/366 ... yes
61/367 ... yes
35/368 ... yes
71/369 ... yes
71/370 ... yes
35/371 ... yes
1/372 ... yes
1/373 ... yes
50/374 ... yes
50/375 ... yes
71/376 ... yes
82/377 ... yes
82/378 ... yes
85/379 ... yes
35/380 ... yes
35/381 ... yes
83/382 ... yes
71/383 ... yes
84/384 ... yes
71/385 ... yes
71/386 ... yes
71/387 ... yes
35/388 ... yes
35/389 ... yes
88/390 ... yes
87/391 ... yes
74/392 ... yes
49/393 ... yes
57/394 ... yes
88/395 ... yes
88/396 ... yes
69/397 ... yes
88/398 ... yes
94/399 ... yes
49/400 ... yes
83/401 ... yes
18/402 ... yes
74/403 ... yes
74/404 ... yes
97/405 ... yes
71/406 ... yes
88/407 ... yes
76/408 ... yes
1/410 ... yes
71/411 ... yes
49/412 ... yes
74/413 ... yes
74/414 ... yes
98/416 ... yes
98/417 ... yes
92/418 ... yes
100/419 ... yes
98/420 ... yes
98/421 ... yes
84/422 ... yes
83/423 ... yes
98/424 ... yes
98/426 ... yes
101/427 ... yes
98/428 ... yes
100/429 ... yes
98/430 ... yes
98/431 ... yes
98/432 ... yes
98/433 ... yes
61/434 ... yes
98/435 ... yes
98/436 ... yes
74/437 ... yes
97/438 ... yes
98/439 ... yes
102/440 ... yes
82/441 ... yes
103/442 ... yes
74/443 ... yes
85/445 ... yes
85/446 ... yes
71/447 ... yes
3/448 ... yes
84/449 ... yes
3/450 ... yes
74/451 ... yes
98/452 ... yes
3/453 ... yes
106/454 ... yes
106/455 ... yes
106/456 ... yes
71/457 ... yes
70/458 ... yes
70/459 ... yes
70/460 ... yes
80/461 ... yes
3/462 ... yes
106/464 ... yes
106/478 ... yes
108/479 ... yes
110/484 ... yes
110/485 ... yes
110/486 ... yes
110/487 ... yes
110/488 ... yes
110/489 ... yes
110/490 ... yes
110/491 ... yes
110/492 ... yes
110/493 ... yes
110/494 ... yes
110/495 ... yes
110/496 ... yes
110/497 ... yes
110/498 ... yes
110/499 ... yes
110/500 ... yes
110/501 ... yes
110/502 ... yes
110/503 ... yes
110/504 ... yes
110/505 ... yes
110/506 ... yes
110/507 ... yes
110/508 ... yes
110/509 ... yes
110/510 ... yes
110/511 ... yes
110/512 ... yes
110/513 ... yes
110/514 ... yes
110/515 ... yes
92/516 ... yes
110/517 ... yes
110/518 ... yes
71/519 ... yes
71/520 ... yes
74/521 ... yes
106/522 ... yes
1/523 ... yes
70/524 ... yes
70/525 ... yes
113/526 ... yes
106/527 ... yes
106/528 ... yes
106/529 ... yes
114/530 ... yes
106/531 ... yes
114/532 ... yes
110/533 ... yes
43/535 ... yes
110/536 ... yes
110/537 ... yes
110/538 ... yes
110/539 ... yes
110/540 ... yes
110/541 ... yes
110/542 ... yes
110/543 ... yes
57/544 ... yes
106/545 ... yes
74/546 ... yes
49/547 ... yes
110/548 ... yes
84/549 ... yes
83/550 ... yes
71/551 ... yes
106/552 ... yes
50/553 ... yes
110/554 ... yes
110/555 ... yes
110/556 ... yes
1/557 ... yes
57/558 ... yes
110/559 ... yes
54/560 ... yes
49/561 ... yes
71/563 ... yes
115/564 ... yes
116/565 ... yes
110/566 ... yes
113/567 ... yes
70/568 ... yes
113/569 ... yes
110/570 ... yes
8/571 ... yes
110/572 ... yes
110/573 ... yes
113/574 ... yes
113/575 ... yes
106/576 ... yes
50/577 ... yes
110/578 ... yes
110/579 ... yes
110/580 ... yes
110/581 ... yes
125/582 ... yes
110/583 ... yes
77/584 ... yes
127/585 ... yes
110/586 ... yes
110/587 ... yes
110/588 ... yes
110/589 ... yes
83/590 ... yes
125/591 ... yes
125/592 ... yes
106/593 ... yes
113/594 ... yes
110/595 ... yes
133/597 ... yes
133/598 ... yes
110/599 ... yes
71/600 ... yes
83/601 ... yes
71/602 ... yes
110/603 ... yes
110/604 ... yes
50/605 ... yes
110/606 ... yes
110/607 ... yes
74/608 ... yes
50/609 ... yes
124/610 ... yes
138/611 ... yes
3/612 ... yes
88/613 ... yes
50/614 ... yes
1/615 ... yes
103/616 ... yes
74/617 ... yes
110/618 ... yes
110/619 ... yes
61/620 ... yes
88/635 ... yes
110/636 ... yes
142/637 ... yes
142/638 ... yes
105/639 ... yes
104/640 ... yes
3/641 ... yes
144/642 ... yes
144/643 ... yes
145/644 ... yes
50/645 ... yes
146/646 ... yes
146/647 ... yes
83/648 ... yes
147/649 ... yes
147/650 ... yes
83/651 ... yes
145/653 ... yes
110/654 ... yes
146/655 ... yes
26/656 ... yes
26/657 ... yes
26/658 ... yes
113/659 ... yes
83/660 ... yes
110/661 ... yes
3/662 ... yes
100/663 ... yes
148/664 ... yes
3/665 ... yes
149/666 ... yes
110/667 ... yes
149/668 ... yes
1/669 ... yes
9/670 ... yes
152/671 ... yes
1/672 ... yes
9/673 ... yes
147/674 ... yes
147/675 ... yes
147/676 ... yes
147/677 ... yes
147/678 ... yes
110/679 ... yes
153/680 ... yes
8/681 ... yes
8/682 ... yes
147/683 ... yes
61/684 ... yes
71/685 ... yes
3/686 ... yes
110/687 ... yes
110/688 ... yes
110/689 ... yes
Redis version >= 4.0.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.6)
Git version >= 2.24.0 ? ... yes (2.28.0)
Git user has default SSH configuration? ... yes
Active users: ... 38
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished

mentioned in issue gitlab-org/quality/triage-reports#356 (closed)

mentioned in issue gitlab-org/quality/triage-reports#357 (closed)

added devopsmanage groupauthentication and authorization [DEPRECATED] severity4 typebug labels

added sectiondev label

mentioned in issue #243448 (closed)

mentioned in issue #246438 (closed)

mentioned in issue #249039 (closed)

mentioned in issue #254141 (closed)

mentioned in issue #257766 (closed)

mentioned in issue #261974 (closed)

mentioned in issue gitlab-org/quality/triage-reports#468 (closed)

changed milestone to %Backlog

added [deprecated] Accepting merge requests label

Setting label(s) ~"Category:Authentication and Authorization" based on ~"group::access".

added 1 deleted label

added vintage label

Hi @l.stoetzel ,

Thanks for raising this bug.

Contributions like this are vital to help make GitLab a better product.

We would be grateful for your help in verifying whether your bug report requires further attention from the team. If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please comment on this issue.

This issue has been inactive for more than 12 months now and based on the policy for inactive bugs, will be closed in 7 days.

Thanks for your contributions to make GitLab better!

added stale label

Hi @l.stoetzel ,

Based on the policy for inactive bugs, this issue is now being closed.

If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please reopen this issue.

Thanks for your contributions to make GitLab better!

closed

added auto closed label